Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: remove onig #5515

Closed
wants to merge 1 commit into from
Closed

expr: remove onig #5515

wants to merge 1 commit into from

Conversation

tertsdiepraam
Copy link
Member

Step towards: #1145

Also relevant: #5210

This is an intentional regression. I think we should remove onig in any case and we should either find or implement a pure Rust regex syntax.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

GNU testsuite comparison:

GNU test failed: tests/chmod/usage. tests/chmod/usage is passing on 'main'. Maybe you have to rebase?

@tertsdiepraam
Copy link
Member Author

Before we merge this, we might want to think about this: rust-lang/regex#1126

@uutils uutils deleted a comment from github-actions bot Nov 21, 2023
@sylvestre
Copy link
Contributor

needs rebasing

sylvestre
sylvestre requested changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@sylvestre
Copy link
Contributor

should we close it ? thanks :)

@sylvestre sylvestre closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

@sylvestre sylvestre sylvestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tertsdiepraam @sylvestre @cakebaker